fix: Stop validating View-provided stream name against instrument name syntax#3518
Merged
cijothomas merged 3 commits intoMay 20, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3518 +/- ##
=======================================
- Coverage 82.8% 82.8% -0.1%
=======================================
Files 130 130
Lines 27289 27262 -27
=======================================
- Hits 22618 22591 -27
Misses 4671 4671 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cijothomas
changed the title
lalitb
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the OpenTelemetry specification clarification in open-telemetry/opentelemetry-specification#5094, the View-provided stream
nameis NOT subject to the instrument name syntax and the SDK MUST NOT validate it against that syntax.Removes the name-syntax validation (empty / length / first-char-alpha / allowed-chars) from
StreamBuilder::build().unit, cardinality limit, and histogram-bucket validation are unchanged. Direct instrument creation viaMetercontinues to enforce the syntax.Spec PR: open-telemetry/opentelemetry-specification#5094
Update (2026-05-19): Spec PR open-telemetry/opentelemetry-specification#5094 has been merged.